IOT Config Gateway v2 #1072
Open
IOT Config Gateway v2 #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macpie
force-pushed
the
macpie/iot_config_gateway_v2
branch
from
af6c6c3 to
770f289
Compare
macpie
force-pushed
the
macpie/iot_config_gateway_v2
branch
from
fac8be3 to
06a07e0
Compare
macpie
force-pushed
the
macpie/iot_config_gateway_v2
branch
from
06a07e0 to
abb42a9
Compare
| .signing_keypair() | ||
| .map(|keypair| keypair.public_key().to_string())?; | ||
| tracing::debug!("listening on {listen_addr}"); | ||
| tracing::debug!("signing as {pubkey}"); |
Contributor
There was a problem hiding this comment.
@bbalser Do we want take this opportunity to log the settings?
| let (tx, rx) = tokio::sync::mpsc::channel(20); | ||
|
|
||
| tokio::spawn(async move { | ||
| let epoch: DateTime<Utc> = "1970-01-01T00:00:00Z".parse().unwrap(); |
Contributor
There was a problem hiding this comment.
chrono provides a constant for the epoch.
DateTime::UNIX_EPOCH;
Also, DateTime::<Utc>::default() is UNIX_EPOCH. We could consider passing epoch as an Option<DateTime<Utc>> to stream_all_gateways_info and .unwrap_or_default() when it's empty if that's more readable.
I don't know we're gaining anything from this function being called in a tokio::select! with a single branch.
| .bind(min_last_changed_at) | ||
| .bind(min_location_changed_at) | ||
| .fetch(db) | ||
| .map_err(anyhow::Error::from) |
Contributor
There was a problem hiding this comment.
Should we be .inspect_err() here so we're not silently ignoring potential errors?
| biased; | ||
| _ = &mut shutdown => break, | ||
| _ = interval.tick() => { | ||
| if let Err(err) = execute(&self.pool, &self.metadata).await { |
Contributor
There was a problem hiding this comment.
We don't want to propagate this err and crash the service if it happens?
michaeldjeffrey
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway/gateway/tracker